JimWeaver/Mixer
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: self-follow validation + add follow/unfollow tests

Browse Source 
Self-follow check used get_attribute(:follower_id) which is nil at
validation time because relate_actor runs after validations in Ash.
Fixed to use context.actor.id directly.

Added 9 tests covering: follow, follow idempotency, self-follow
prevention, guest restriction, unfollow, unfollow noop,
guest unfollow, follower/following counts, and am_i_following.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
qdust41
2026-04-12 19:54:43 -04:00
parent df8bc97bd2
commit d7345ba234
3 changed files with 179 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
fix_plan.md
View File

@@ -11,11 +11,13 @@
## Backlog
- [x] Self-follow validation used `get_attribute(:follower_id)` which is nil at validation time (relate_actor runs after) — fixed to use `context.actor.id`
- [x] Follow/unfollow test coverage (9 tests)
- [ ] No pagination on user list (`/users`)
- [ ] No CHECK constraint on `likes >= 0` at DB level (low priority, app logic prevents it)
- [ ] `read :following_feed` returns error if actor is nil — should be policy-guarded
- [ ] `read :following_feed` — nil actor returns empty list (not a bug)
- [ ] No search for users or tweets
- [ ] Missing test coverage: follow/unfollow, comments, tweet creation, auth flows
- [ ] Missing test coverage: comments, tweet creation, auth flows
## Notes